Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue: 101] Clean up and toString versions of DateTime support methods #103

Merged
merged 3 commits into from
Oct 28, 2020

Conversation

0xEljh
Copy link

@0xEljh 0xEljh commented Oct 28, 2020

Added toString versions of DateTime support methods:
getInDateTimeRangeToString() and getAfterDateTimeToString() to support printing of FoodList to user.

Additionally:
Fix #101

Calculator and FoodList no longer reference each other via static method/variables. Instance of FoodList passed to calculator as a parameter for now.
Redundant old file mistakenly added. Likely due to merge conflict resolution.
-Tweak test method execution order for robustness of `LocalDateTime.now()`
- add methods to fetch portion of list in string representation using dates.
Copy link

@HengFuYuen HengFuYuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current commit LGTM.

@@ -61,11 +61,14 @@ void dateComparisonTest() {

@Test
void dateFilterAfterTest() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps consider using the three-part naming style for the tests.

@HengFuYuen HengFuYuen merged commit 097fb48 into master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FoodList has static variable and methods
2 participants